fix(#924): add revert to allowed gitlint commit types - #926
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
fix(#924): add revert to allowed gitlint commit types#926fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
The .gitlint config restricted commit types to feat,fix,refactor,docs,test,chore,ci,perf,build, omitting the standard Conventional Commits 'revert' type. This caused CI commit-lint failures for legitimate revert commits (e.g., PR #923). Add 'revert' to the types list in .gitlint and update AGENTS.md section 4 to document it as an allowed prefix. Closes #924
|
🤖 Finished Review · ✅ Success · Started 3:09 PM UTC · Completed 3:20 PM UTC Commit: |
ReviewFindingsMedium
|
fullsend-ai-review
Bot
added
the
requires-manual-review
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
revertto the allowed commit types in.gitlint([contrib-title-conventional-commits]section)revertto the documented type prefixes inAGENTS.mdsection 4 ("Commit message format")Context
PR #923 used a
revert(skillsaw):commit type which is valid per the Conventional Commits spec but was rejected by thecommit-lintCI job because.gitlintdid not includerevertin its allowed types list. This was a configuration gap — all other standard Conventional Commits types were already present.Testing
Verified locally with gitlint:
revert(skillsaw): restore skill namesnow passes the type check (previously failed with CT1)undo(skillsaw): restore skill namesstill fail as expectedpost-retro-test.share unrelated)Closes #924
Post-script verification
agent/924-add-revert-commit-type)7ad7b5000373150ce1bf1a312dd6713045bea8f8..HEAD)